Re: UTF-8 to ANSI hack in CAboutDialog

Right, I’ll change it to this so it doesn’t get broken again:

     if (str.Find('\xC2') != wxNOT_FOUND)
         str.Remove(str.Find('\xC2'), 1);

mmalmi@cc.hut.fi wrote:

I didn’t change it knowingly, must have been some encoding problem.

What was the reason for this change?

#if !wxUSE_UNICODE … if (str.Find(‘Â’) != wxNOT_FOUND) str.Remove(str.Find(‘Â’), 1); to: if (str.Find(‘�’) != wxNOT_FOUND) str.Remove(str.Find(‘�’), 1);

wxFormBuilder turns the (c) symbol into UTF-8 automatically. On wxWidgets-2.8.9 ansi, it shows as a copyright symbol with an extra trash character, which this hack fixes up for the non-unicode (ansi) case.

Source: Published by Martti Malmi on GitHub in February 2024 as part of his testimony in the COPA v. Wright trial. The full correspondence archive is available at mmalmi.github.io/satoshi/.